aglinxinyuan commented on PR #6185:
URL: https://github.com/apache/texera/pull/6185#issuecomment-4888397529

   Heads up — the plain `netty-transport` bump can't stand on its own here. 
Netty is pinned as one coordinated family (`build.sbt` + 
`common/workflow-core/build.sbt`) because `arrow-memory-netty` reaches into 
Netty allocator internals, and Apache Arrow `15.0.2` requires the 4.1 line. 
Bumping only `netty-transport`/`netty-transport-native-unix-common` to 4.2 
split the family across the 4.1/4.2 boundary, which is why `amber-integration` 
and `Bench` crashed with:
   
   ```
   java.lang.NoClassDefFoundError: io/netty/util/concurrent/ThreadAwareExecutor
       at io.netty.channel.nio.NioEventLoopGroup.newChild
       at io.grpc.netty.Utils$DefaultEventLoopGroupResource.create
   ```
   
   (`ThreadAwareExecutor` is new in `netty-common` 4.2, but `netty-common` was 
still pinned at 4.1.96.)
   
   Arrow `19.0.0` is the first released Arrow that targets the Netty 4.2 line, 
so I turned this into the coordinated upgrade it needs:
   
   - Apache Arrow `15.0.2 → 19.0.0` (`flight-grpc` was discontinued after 
15.0.2 and folded into `flight-core`)
   - entire Netty family → `4.2.15.Final`, pinned via a shared `nettyVersion`
   - `LICENSE-binary` / `NOTICE-binary` re-synced for the transitive cascade 
(grpc `1.62→1.79`, protobuf `3.25→4.33`, Netty 4.2)
   
   **Test results on the latest push:**
   
   | Check | Result |
   |---|---|
   | `build / amber-integration` (ubuntu, 17) | ✅ pass |
   | `build / amber-integration` (macos, 17) | ✅ pass |
   | `Bench` (arrow-flight-e2e) | ✅ pass (6m43s) |
   | `build / amber` — compile + dist | ✅ pass |
   
   The runtime crash is gone — the Python-worker Arrow Flight transport comes 
up cleanly on both OSes and the arrow-flight benchmark runs end to end. 
Remaining red is `LICENSE-binary` / `NOTICE-binary` version drift from the 
cascade, which I'm finishing now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to