Yicong-Huang commented on PR #6143: URL: https://github.com/apache/texera/pull/6143#issuecomment-4898863157
> @Xiao-zhen-Liu Please chime in. > > @Yicong-Huang A general question: should we create a discussion first? Or in what cases should we create a discussion before raising a PR? We create discussions when there could have different opinions, for instance when we are unsure if support a feature or not, when we are not sure whether support something or not, or whether we want to remove/disable something. The discussion usually is on the direction. For this particular case, I feel having two copies of the compiler source code is problematic and adds maintenance cost. Thus, I did not ask for input to unifying them by creating a shared lib. There is no change on the design, or experience: we still do two compilations, one at editing time, through compilation service, one at execution time, through execution service. Thus I did not do a discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
