aglinxinyuan commented on code in PR #6224: URL: https://github.com/apache/texera/pull/6224#discussion_r3549771831
########## project/plugins.sbt: ########## @@ -40,5 +40,5 @@ libraryDependencies ++= Seq( // PostgresDatabase.loadForeignKeys can't read (it looks up lowercase key_seq), // breaking JOOQ code generation. Fixed only in jOOQ 3.20+ (jOOQ/jOOQ#17873); until // the codegen jOOQ is upgraded, keep this driver at the last compatible release. - "org.postgresql" % "postgresql" % "42.7.4" + "org.postgresql" % "postgresql" % "42.7.13" Review Comment: Good catch — and correct. Reverted this line back to `42.7.4` in 9056542; the codegen driver has to stay on the last jOOQ-3.16.23-compatible pgjdbc (the `KEY_SEQ` casing only reads correctly on jOOQ 3.20+, jOOQ/jOOQ#17873). Only the runtime driver in `amber/build.sbt` moves to 42.7.13. ########## amber/build.sbt: ########## @@ -255,7 +255,7 @@ libraryDependencies += "com.flipkart.zjsonpatch" % "zjsonpatch" % "0.4.16" libraryDependencies += "io.reactivex.rxjava3" % "rxjava" % "3.1.12" // https://mvnrepository.com/artifact/org.postgresql/postgresql -libraryDependencies += "org.postgresql" % "postgresql" % "42.7.12" +libraryDependencies += "org.postgresql" % "postgresql" % "42.7.13" Review Comment: Done — synced `amber/LICENSE-binary-java` to 42.7.13 in 9056542 (postgresql is a direct amber dep, so its bundled-jar entry is version-checked). On consolidating across subprojects — the three pins are intentionally separate: - `project/plugins.sbt` (42.7.4) is a build-time-only codegen/sbt classpath, not bundled, and can't advance until `jooq-codegen` is upgraded past 3.16. - The platform services still list 42.7.10 because pgjdbc is only a *transitive* dep there; the PR-mode check runs with `--ignore-transitive-version`, so that drift is tolerated — it's the same state `main` is already in. So no silent eviction to worry about here — just amber's own direct runtime driver advancing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
