roshiiiz commented on PR #6288: URL: https://github.com/apache/texera/pull/6288#issuecomment-4930664622
@aglinxinyuan This PR is ready for final review and merge! I've gone through several rounds of Copilot AI reviews and addressed all of the architectural feedback. (Honestly, I had to stop because it kept nitpicking **unrelated** code until I literally hit my quota limit for reviews ). To summarize the final state of this PR: **Frontend**: Normalized compilation and execution errors by stripping out the raw Java/Scala exception prefixes so users get clean, readable validation messages. **Backend Validation:** Added explicit require() validations to Projection, SQL, and AsterixDB sources so they fail gracefully with actionable UI messages when an operator is added but left unconfigured. **File Sources:** Hardened the file-based sources (Arrow, CSV) to catch invalid selections (like selecting a folder instead of a file) early during schema inference. **State Cleanups:** Refactored the CSV operators (CSVScanSourceOpDesc, ParallelCSVScanSourceOpDesc, CSVOldScanSourceOpDesc) to remove side-effect mutations during sourceSchema() inference (which was the final thing Copilot was complaining about). The local dev stack is passing all tests. Could you please take a look and approve? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
