Mrudhulraj commented on PR #6016:
URL: https://github.com/apache/texera/pull/6016#issuecomment-4932634178
I have done some analysis @Yicong-Huang,
The endpoints are clearly decoupled both for workflows and datasets (Good
News!!).
The issue lies with DashboardResource behavior, causing a cluttered feel.
Here is a dependency graph with file locations for each:
```mermaid
graph TD
%% Base Layer
DR[DatasetResource<br>file-service & amber] -->
Dash[DashboardResource<br>amber]
WR[WorkflowResource<br>amber] --> Dash
%% Downstream Layer
Dash --> HS[Hubservice<br>amber]
Dash --> WRS[WorkflowResourcespec<br>amber]
Dash --> QB[Query Builders<br>amber]
%% Isolated Flow
DRS[DatasetResourceSpec<br>file-service] --> DBC[Database Checks]
```
Clearly, the `DashBoardResource` depends on `workflowResource` and
`datasetResource` defined in amber. Here (amber), datasetResource is minimally
defined.
- All endpoints for datasetResource are defined in file-service instead.
- Adding a testcase to `datasetResourcespec` is not possible as it can
access only check Dao methods and not the dashboard apis'.
Fix:
Create/mimic the `DashboardResource `file in file-services.
OR
move `DashboardResource `to common -> affects querybuilders in amber as
there is an interdependency here.
cc: @carloea2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
