Yicong-Huang commented on code in PR #6131:
URL: https://github.com/apache/texera/pull/6131#discussion_r3561151649
##########
amber/src/main/scala/org/apache/texera/web/resource/pythonvirtualenvironment/PveManager.scala:
##########
@@ -94,11 +94,15 @@ object PveManager {
}
}
+ // The lock file is copied to /tmp/system-requirements-lock.txt inside every
+ // deployed image (see bin/computing-unit-master.dockerfile), so single-node
+ // Docker and Kubernetes both find it there. Only a source-tree dev run reads
+ // the repo-relative amber/ copy. `isLocal` alone can't distinguish a
+ // containerized single-node run (also non-k8s) from a dev run, so probe.
private def getSystemPath(isLocal: Boolean): Path = {
- Paths.get(
- if (isLocal) "amber/system-requirements-lock.txt"
- else "/tmp/system-requirements-lock.txt"
- )
+ val deployPath = Paths.get("/tmp/system-requirements-lock.txt")
+ if (Files.exists(deployPath)) deployPath
+ else Paths.get("amber/system-requirements-lock.txt")
Review Comment:
ok. please annotate `fix(pve, v1.2)` in PR title so we know this is
targeting v1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
