Amer-Mukhtar opened a new pull request, #6345:
URL: https://github.com/apache/texera/pull/6345
Description
What changes were proposed in this PR?
This PR adds unit test coverage for parseLogicalOperatorPortID in
frontend/src/app/common/util/logical-operator-port-serde.ts. This is a pure
parser function that converts a port-id string into a structured object, and it
previously had no tests. A new spec file, logical-operator-port-serde.spec.ts,
was added following the style of the existing size-formatter.util.spec.ts. It
covers valid inputs, where "input-0" parses to { portNumber: 0, portType:
"input" } and "output-12" parses to { portNumber: 12, portType: "output" }, as
well as invalid inputs such as "foo-1", "input-", "input-1-2", and the empty
string, which all return undefined. This is a test-only change and no
production code was modified.
Any related issues, documentation, discussions?
Closes #6257
How was this PR tested?
The new unit tests were run via ng test (vitest runner) and all 6 tests
pass. The new file was also checked with prettier and eslint, both of which are
clean.
Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
