aglinxinyuan commented on code in PR #5700:
URL: https://github.com/apache/texera/pull/5700#discussion_r3565699566
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/core/workflow/PhysicalOp.scala:
##########
@@ -208,6 +208,9 @@ case class PhysicalOp(
// restricting it to only the requiring operator's regions is a possible
// future optimization. Default false.
requiresMaterializedExecution: Boolean = false,
Review Comment:
Added a `logger.warn` at the `createRegionDAG` call site when the effective
mode differs from the requested one, naming the operator(s) that require
materialized execution — e.g. `Overriding requested execution mode PIPELINED
with MATERIALIZED: operator(s) LoopStart-operator-... require materialized
execution.` Kept `effectiveExecutionMode` itself pure since its unit tests call
it directly. Surfacing it in the UI (a websocket/console message at schedule
time) would need an RPC channel the schedule generator doesn't hold today —
happy to file that as a follow-up if you think it's worth it. (39fceda)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
