aicam commented on PR #6240: URL: https://github.com/apache/texera/pull/6240#issuecomment-4962668253
@Yicong-Huang Both points addressed: **`enableSharedEditing` config:** removed entirely in 3ae20d718. Instead of a flag, `SharedModel` now connects lazily — it opens a `/rtc` socket only when a workflow ID is provided, which is the contract `loadNewYModel(workflowId, ...)` already documented. Graphs without a `wid` (throwaway validation/compilation graphs, test fixtures, unsaved canvases) are local-only by construction, so `WorkflowGraph`'s constructor is back to its original 3-argument signature and carries no shared-editing configuration. PR description updated to match. **Backport to v1.2:** I'd say yes for the frontend commit — the per-edit leak exists in v1.2 as well, and any deployment fronted by a connection-capped proxy will eventually hit it. The frontend change is small and self-contained, so it should cherry-pick cleanly. The k8s/gateway part is optional for the backport (it only applies to Envoy Gateway deployments); happy to open the backport PR once this merges if you'd like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
