Xiao-zhen-Liu commented on PR #6238: URL: https://github.com/apache/texera/pull/6238#issuecomment-4965662958
@Neilk1021 thanks for the fast iterations — most threads are addressed. A few are still open on your side to resolve or follow up: - **`shutdownDB` naming** — looks handled by the rename to `closeConnectionPool`; feel free to resolve that thread. - **TestUtils dedup (item 1)** — just needs the follow-up issue we agreed on; link it here and resolve. - **Global `SqlServer` repointed per test** — agreed this is future work toward #4525; a one-line note here (or leaving it open as a tracked concern) is enough to close it from my side. - **`getDBInstance`/two init entry points** — minor nit, your call: a quick doc line or a "won't fix" closes it. No blockers from me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
