Copilot commented on code in PR #6408: URL: https://github.com/apache/texera/pull/6408#discussion_r3583798457
########## project/plugins.sbt: ########## @@ -40,5 +40,5 @@ libraryDependencies ++= Seq( // PostgresDatabase.loadForeignKeys can't read (it looks up lowercase key_seq), // breaking JOOQ code generation. Fixed only in jOOQ 3.20+ (jOOQ/jOOQ#17873); jOOQ // is capped at 3.19.36 here (the last Java-17 release), so keep this driver pinned. - "org.postgresql" % "postgresql" % "42.7.4" + "org.postgresql" % "postgresql" % "42.7.13" Review Comment: The comment above says the JOOQ codegen JDBC driver must be pinned to 42.7.4 because pgjdbc >= 42.7.5 changes metadata column labels in a way that breaks jOOQ 3.19.x. Updating this dependency to 42.7.13 makes that rationale inaccurate and risks breaking code generation unless jOOQ is also upgraded or the issue is otherwise mitigated. ########## computing-unit-managing-service/build.sbt: ########## @@ -49,7 +49,7 @@ libraryDependencies ++= Seq( "io.kubernetes" % "client-java" % "21.0.0", "org.jooq" % "jooq" % "3.19.36", "com.typesafe" % "config" % "1.4.9", - "com.softwaremill.sttp.client4" %% "core" % "4.0.25", + "com.softwaremill.sttp.client4" %% "core" % "4.0.26", "com.typesafe.play" %% "play-json" % "2.10.6", Review Comment: Bumping sttp client4 core to 4.0.26 will make the per-service LICENSE-binary drift: computing-unit-managing-service/LICENSE-binary currently lists com.softwaremill.sttp.client4.core_2.13-4.0.25.jar (lines 261-264). CI checks the unzipped dist lib dir against this file (see .github/workflows/build.yml:731-749), so the LICENSE-binary entry needs to be updated to 4.0.26 (and any other version changes in the dist) for the build to pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
