aicam opened a new pull request, #6472:
URL: https://github.com/apache/texera/pull/6472

   ### What changes were proposed in this PR?
   
   A small, behavior-preserving refactor of the Helm chart layout under 
`bin/k8s`.
   
   The agent-service **`BackendTrafficPolicy`** is a gateway-layer [Envoy 
Gateway](https://gateway.envoyproxy.io/) resource — it configures 
consistent-hash load balancing on the gateway for the agent-service `HTTPRoute` 
(so all requests for a given workflow pin to the same replica). Despite being a 
gateway concern, it was living under `templates/base/agent-service/` next to 
the app-tier `Deployment`/`Service`/`Secret`.
   
   It is the same class of resource as the `SecurityPolicy` 
(`gateway-security-policy.yaml`) that already lives in 
`templates/base/gateway/`, so this PR moves it there and renames it to the 
folder's `gateway-*` convention:
   
   ```
   templates/base/agent-service/agent-service-backend-traffic-policy.yaml
     -> templates/base/gateway/gateway-agent-traffic-policy.yaml
   ```
   
   After this move, **every** gateway-related resource (`GatewayClass`, 
`Gateway`, `HTTPRoute`, `Backend`, `SecurityPolicy`, `BackendTrafficPolicy`) 
lives under `templates/base/gateway/`, and no gateway resource remains 
scattered in a service folder (verified by grepping all templates for the 
`gateway.envoyproxy.io` / `gateway.networking.k8s.io` API groups — this was the 
only stray one).
   
   This is purely organizational: no values, resource names, gating conditions, 
or rendered output change. It continues the `base`/`aws`/`on-prem` template 
reorganization from #5757.
   
   ### Any related issues, documentation, discussions?
   
   Part of the deployment-unification effort tracked in #5891 (housekeeping 
follow-up to the template reorg in #5757). No functional dependency on the 
object-storage work (#5932, #6295).
   
   ### How was this PR tested?
   
   Verified the move is byte-for-byte behavior-preserving by diffing the 
rendered manifests before and after:
   
   ```bash
   cd bin/k8s
   helm dependency build   # fetch subcharts
   
   # render with the file in its OLD location
   helm template test . > /tmp/before.txt
   
   # render with the file in its NEW location (this PR)
   helm template test . > /tmp/after.txt
   
   diff /tmp/before.txt /tmp/after.txt
   ```
   
   The only differences are:
   1. The `# Source:` provenance comment path (`.../agent-service/...` → 
`.../gateway/...`) — expected, cosmetic.
   2. The auto-generated `encryptionKey` value — Helm regenerates this random 
secret on every invocation; unrelated to this change.
   
   The `BackendTrafficPolicy` resource itself (name 
`<release>-agent-service-traffic-policy`, its `targetRefs`, and the 
`X-Agent-Workflow-Id` consistent-hash config) renders identically. `helm 
template` succeeds for the default value set.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 4.8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to