Yicong-Huang commented on code in PR #6377:
URL: https://github.com/apache/texera/pull/6377#discussion_r3601172187
##########
.github/workflows/build.yml:
##########
@@ -639,6 +639,19 @@ jobs:
# amber/src/main/resources/web-config.yml (port 8080).
if: matrix.os == 'ubuntu-latest'
run: .github/scripts/smoke-boot.sh
"/tmp/dists/amber-*/bin/texera-web-application" 8080
+ - name: Smoke-test computing-unit-master boots
+ # computing-unit-master boots on postgres only, like texera-web: main
+ # starts a LOCAL Pekko actor master (clusterMode defaults to false with
+ # no --cluster arg, so no external seed/discovery and the cluster-only
+ # checkip.amazonaws.com lookup is never reached), then run() calls
+ # SqlServer.initConnection against the postgres provisioned above. The
+ # boot-time result-store cleanup is gated on
+ # ApplicationConfig.cleanupAllExecutionResults, which defaults to
false,
+ # so no iceberg / S3 access. Config resolves via Utils.amberHomePath to
+ # amber/src/main/resources/computing-unit-master-config.yml (port
8085).
+ # Reuses the amber dist built + unzipped above for the texera-web boot.
+ if: matrix.os == 'ubuntu-latest'
+ run: .github/scripts/smoke-boot.sh
"/tmp/dists/amber-*/bin/computing-unit-master" 8085
Review Comment:
do we also need to smoke test the CU worker node ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
