rbelavadi opened a new pull request, #6493: URL: https://github.com/apache/texera/pull/6493
### What changes were proposed in this PR? Extracted the dataset settings/admin functionality on the dataset detail page into a dedicated Settings tab, alongside existing content (now under a Data Card tab). Part of the parent tab-based layout refactor (#6394). Visibility toggle, downloadable toggle, and description editor moved from the header's gear-icon popover into the new Settings tab. The gear icon and popover are removed. Added dataset rename (input + Save), calling the existing `DatasetService.updateDatasetName()` and reusing the name-sanitization logic already used in the dataset version creator. Added dataset delete, calling the existing `DatasetService.deleteDatasets()` with the same `nz-popconfirm` confirmation pattern used on the Datasets list page; redirects to the list on success. Before: settings were scattered, visibility/downloadable behind a gear icon, description editable only in the header, rename/delete only reachable from the Datasets list page. <img width="1915" height="1015" alt="settings_tab_recording_old" src="https://github.com/user-attachments/assets/3d29d0f3-0fbb-4caa-8c8f-ee0348df0ab1"; /> After: all dataset settings are consolidated in one Settings tab on the detail page itself. <img width="1915" height="1018" alt="settings_tab_recording" src="https://github.com/user-attachments/assets/348effd0-e8fd-4583-baff-118af9c83fee"; /> ### Any related issues, documentation, discussions? Closes #6395 ### How was this PR tested? Manually tested on UI, since this is a reorganization of existing functionality with no changes to underlying behavior: - Renamed a dataset; confirmed persistence and correct sanitization of invalid characters. - Edited and saved the description; confirmed it reflects on the Datasets list page. - Toggled visibility and downloadable; confirmed state persists and header badges update accordingly. - Deleted a test dataset; confirmed confirmation prompt, successful deletion, and redirect to the Datasets list with the dataset removed. - Confirmed the Data Card tab (file browser, version history, uploads) is unaffected. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
