aglinxinyuan commented on code in PR #6488: URL: https://github.com/apache/texera/pull/6488#discussion_r3607100514
########## common/workflow-core/src/main/scala/org/apache/texera/amber/util/WinutilsFreeLocalFileSystem.scala: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.util + +import org.apache.hadoop.fs.permission.FsPermission +import org.apache.hadoop.fs.{LocalFileSystem, Path, RawLocalFileSystem} +import org.apache.hadoop.util.Shell + +/** + * A Hadoop local file system that never shells out to `winutils.exe`. + * Review Comment: Reworded in f68aad006d — the doc now says it works without a winutils installation and spells out that it delegates to Hadoop's default behavior (including winutils/chmod) when winutils is available or on non-Windows hosts. Also fixed the stale "empty Hadoop `Configuration`" line on `createHadoopCatalog` while at it. ########## common/workflow-core/src/main/scala/org/apache/texera/amber/util/IcebergUtil.scala: ########## @@ -58,6 +59,27 @@ object IcebergUtil { // Unique suffix for LARGE_BINARY field encoding private val LARGE_BINARY_FIELD_SUFFIX = "__texera_large_binary_ptr" + /** + * Creates the Hadoop `Configuration` used by catalogs that access the local file + * system through `HadoopFileIO`. + * + * On Windows hosts without a native Hadoop installation (winutils.exe), Hadoop's + * default local file system fails on every write because it shells out to winutils + * for chmod. In that case, swap in [[WinutilsFreeLocalFileSystem]], which skips + * permission operations, so local development works without installing winutils. + * On all other hosts the default configuration is returned unchanged. + */ + private def newLocalHadoopConf(): Configuration = { Review Comment: Thanks for digging up the timeline — matches what I saw locally (fine on 3.3.1, first crash right after the bumps). Both asks addressed: 1. Description refreshed — `rest` is now called out as the stock default (#6049), the before/after table is scoped to the `postgres`/`hadoop` types, and the 3.3.1 → 3.4.3/3.5.0 regression window is included. 2. Noted in the PR body for #6150 — `WinutilsFreeLocalFileSystemSpec` already drives the file system directly through `fs.file.impl`, so when the `hadoop` type is removed the `IcebergUtilSpec` case can be re-anchored there (or on the `postgres` catalog) without losing coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
