mengw15 opened a new issue, #6517:
URL: https://github.com/apache/texera/issues/6517

   ### Task Summary
   
   
`frontend/src/app/dashboard/component/admin/settings/admin-settings.component.ts`
 (codecov ~35%) has a spec but it only asserts `should create`. **Extend it** 
to cover the untested save/reset handlers (all currently uncovered). See 
`frontend/TESTING.md`; mock `AdminSettingsService` + `NotificationService`.
   
   ### Behavior to add
   
   - `saveLogos` / `saveTabs` / `saveCsvSettings` / `saveDatasetSettings` -> 
each persists via the settings service; success/error notifications
   - `resetBranding` / `resetTabs` / `resetCsvSettings` / 
`resetDatasetSettings` -> reset the respective settings
   - `onFileChange` -> handles the logo file input
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to