Copilot commented on code in PR #6522:
URL: https://github.com/apache/texera/pull/6522#discussion_r3608258909
##########
amber/src/main/python/core/architecture/handlers/control/end_worker_handler.py:
##########
@@ -38,12 +38,15 @@ async def end_worker(self, req: EmptyRequest) ->
EmptyReturn:
of all the control messages.
"""
# Ensure this is really the last message.
- input_queue: IQueue = self.context.input_queue
+ input_queue: InternalQueue = self.context.input_queue
if not input_queue.is_empty():
logger.warning(
f"Received EndHandler before all messages are "
- f"processed. Unprocessed messages: {input_queue.get()}"
+ f"processed. Unprocessed messages: {input_queue.peek()}"
)
Review Comment:
The warning message says "Received EndHandler" but this is the Python
EndWorker handler. This makes logs harder to search/triage and can be confused
with the Scala EndHandler; update the log text to reference EndWorker (or
EndWorkerHandler).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
