xuang7 commented on code in PR #5675:
URL: https://github.com/apache/texera/pull/5675#discussion_r3608854636
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.html:
##########
@@ -161,7 +161,38 @@ <h5 class="rightAlign"><span
[innerHTML]="compare(column.header, 'other')"></spa
class="table-cell"
nzEllipsis
(click)="open(i, row)">
- <span class="cell-content">{{ column.getCell(row) }}</span>
+ <span class="cell-content">
+ <ng-container [ngSwitch]="getCellMediaType(i, columnIndex)">
Review Comment:
i is the index within basicTable.data, which is a page slice when
isFrontPagination is true, but cellMediaTypes is indexed by position in the
full currentResult. Maybe consider keying by the row object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
