Ma77Ball commented on code in PR #6016:
URL: https://github.com/apache/texera/pull/6016#discussion_r3607782945
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/DatasetSearchQueryBuilder.scala:
##########
@@ -66,30 +66,38 @@ object DatasetSearchQueryBuilder extends SearchQueryBuilder
with LazyLogging {
params: DashboardResource.SearchQueryParams,
includePublic: Boolean = false
): TableLike[_] = {
+ // Case 1: if `uid` is (set) and `includePublic` is false
+ // -> return ONLY datasets that given `uid` has explicit access to.
+ // Case 2: if `uid` is (null) and `includePublic` is true
+ // -> return ONLY datasets that are public
+ // Case 3 (DUPLICATE ROWS): if `uid` is (set) and `includePublic` is true
+ // -> Intersection of datasets that are public and explicitly shared with
user is returned
Review Comment:
Nit: This comment appears inaccurate/stale. The predicate `IS_PUBLIC OR
UID.isNotNull` is a union, not an intersection.
```suggestion
// Case 3: if `uid` is (set) and `includePublic` is true
// -> Union of datasets that are public and datasets explicitly shared
with the user
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
