aglinxinyuan opened a new pull request, #6565:
URL: https://github.com/apache/texera/pull/6565

   ### What changes were proposed in this PR?
   
   Adds a Vitest unit spec for `SearchResultsComponent`, which previously had 
no test coverage. The 17 tests cover:
   - `getUid` for logged-in, spied, and no-user cases.
   - `reset` (clears entries, stores the loader, bumps the internal reset 
counter).
   - `loadMore`: empty-list rejection, append + start-offset advancement, the 
`loading` true→false `finally` transition, and the **reset-during-flight race** 
— a mid-flight `reset()` discards stale results so entries stay empty.
   - `onEntryCheckboxChange` emitting `notifyWorkflow` only when every entry is 
checked (verified by subscribing to the emitter).
   - `selectAll`/`clearAllSelections` and `trackByEntryId`.
   - List- and card-view template rendering (the heavy `ListItemComponent` is 
swapped for a same-selector stub).
   
   ### Any related issues, documentation, discussions?
   
   Closes #6562.
   
   ### How was this PR tested?
   
   `npx ng test --watch=false --include='**/search-results.component.spec.ts'` 
→ 17/17 passing. `yarn format:ci` passes.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to