aglinxinyuan opened a new pull request, #6597:
URL: https://github.com/apache/texera/pull/6597

   ### What changes were proposed in this PR?
   
   Extends the existing `filters.component.spec.ts` with 27 new tests (4 -> 31) 
for `FiltersComponent`, targeting previously-uncovered behavior:
   - login-gated backend setup 
(`retrieveOwners`/`retrieveWorkflowIDs`/`setupUserProject` and their logged-out 
else branches);
   - the owner/id/operator/project checkbox toggles and their 
`masterFilterListChange` emissions;
   - `updateDropdownMenus` valid parsing and invalid-tag notification + 
`removeInvalidFilterTag`;
   - date-tag guards (malformed / duplicate ctime-mtime); and
   - `getSearchFilterParameters` / `getSearchKeywords` assembly.
   
   Adds `StubUserService`/`StubUserProjectService` so the login paths execute, 
plus a fixture-destroy + overlay-clear `afterEach`. Statement/branch/function 
coverage: ~68.5% -> 100%. No existing tests modified.
   
   ### Any related issues, documentation, discussions?
   
   Closes #6594.
   
   ### How was this PR tested?
   
   `npx ng test --watch=false --include='**/filters.component.spec.ts'` -> 
31/31 passing. `yarn format:ci` passes.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to