Copilot commented on code in PR #6693:
URL: https://github.com/apache/texera/pull/6693#discussion_r3626777126
##########
frontend/src/app/workspace/service/compile-workflow/workflow-compiling.service.spec.ts:
##########
@@ -328,3 +329,226 @@ describe("WorkflowCompilingService public getters", () =>
{
expect(service.getOperatorInputAttributeType("op1", 0,
"missing")).toBeUndefined();
});
});
+
+describe("WorkflowCompilingService.setOperatorInputAttrs /
restoreOperatorInputAttrs", () => {
+ const port0 = serializePortIdentity({ id: 0, internal: false });
+
+ // Builds an OperatorSchema wrapping the given json schema. Only jsonSchema
and
+ // (for restore) additionalMetadata.inputPorts matter for these pure
transforms.
Review Comment:
The comment above `makeOperatorSchema` is slightly misleading:
`restoreOperatorInputAttrs` only reads/modifies `operatorSchema.jsonSchema` and
does not use `additionalMetadata.inputPorts`. Consider updating the comment to
reflect that additionalMetadata is included only to satisfy the
`OperatorSchema` shape in this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
