Copilot commented on code in PR #6705: URL: https://github.com/apache/texera/pull/6705#discussion_r3626817268
########## amber/src/test/scala/org/apache/texera/web/service/ResultExportServiceSpec.scala: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.web.service + +import jakarta.ws.rs.core.Response +import org.apache.texera.amber.core.virtualidentity.WorkflowIdentity +import org.apache.texera.web.model.http.request.result.{OperatorExportInfo, ResultExportRequest} +import org.scalatest.flatspec.AnyFlatSpec +import org.scalatest.matchers.should.Matchers + +// Unit tests for the ResultExportService request helpers parseOperators and +// validateExportRequest. Constructing the service is cheap (it only stores the +// identity and computing-unit id), so no engine/DB dependency is needed here. +class ResultExportServiceSpec extends AnyFlatSpec with Matchers { + + private val service = new ResultExportService(WorkflowIdentity(1L), computingUnitId = 0) + + private def requestWith(operators: List[OperatorExportInfo]): ResultExportRequest = + ResultExportRequest( + exportType = "csv", + workflowId = 1, + workflowName = "wf", + operators = operators, + datasetIds = List.empty, + rowIndex = 0, + columnIndex = 0, + filename = "", + computingUnitId = 0 + ) + + // -- parseOperators --------------------------------------------------------- + + "parseOperators" should "deserialize a JSON array into OperatorExportInfo objects" in { + val json = + """[{"id":"op-1","outputType":"csv"},{"id":"op-2","outputType":"arrow"}]""" + val parsed = service.parseOperators(json) + + parsed shouldBe List( + OperatorExportInfo("op-1", "csv"), + OperatorExportInfo("op-2", "arrow") + ) + } + + it should "round-trip an empty JSON array to an empty list" in { + service.parseOperators("[]") shouldBe List.empty[OperatorExportInfo] + } + + it should "throw when given a malformed JSON string" in { + an[Exception] should be thrownBy service.parseOperators("not json") + } + + // -- validateExportRequest -------------------------------------------------- + + "validateExportRequest" should "return a 400 response when no operators are selected" in { + val result = service.validateExportRequest(requestWith(List.empty)) + + result should be(defined) + val response = result.get Review Comment: `result should be(defined)` is the only usage of the `defined` Option matcher in the test suite and may not compile without mixing in the right ScalaTest trait/import; additionally, calling `Option.get` is unsafe and will throw a less-informative error if the assertion is removed/changed. Prefer extracting the response via `getOrElse(fail(...))` so the test is self-contained and fails with a clear message. ########## amber/src/test/scala/org/apache/texera/web/service/ResultExportServiceSpec.scala: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.web.service + +import jakarta.ws.rs.core.Response +import org.apache.texera.amber.core.virtualidentity.WorkflowIdentity +import org.apache.texera.web.model.http.request.result.{OperatorExportInfo, ResultExportRequest} +import org.scalatest.flatspec.AnyFlatSpec +import org.scalatest.matchers.should.Matchers + +// Unit tests for the ResultExportService request helpers parseOperators and +// validateExportRequest. Constructing the service is cheap (it only stores the +// identity and computing-unit id), so no engine/DB dependency is needed here. +class ResultExportServiceSpec extends AnyFlatSpec with Matchers { + + private val service = new ResultExportService(WorkflowIdentity(1L), computingUnitId = 0) + + private def requestWith(operators: List[OperatorExportInfo]): ResultExportRequest = + ResultExportRequest( + exportType = "csv", + workflowId = 1, + workflowName = "wf", + operators = operators, + datasetIds = List.empty, + rowIndex = 0, + columnIndex = 0, + filename = "", + computingUnitId = 0 + ) + + // -- parseOperators --------------------------------------------------------- + + "parseOperators" should "deserialize a JSON array into OperatorExportInfo objects" in { + val json = + """[{"id":"op-1","outputType":"csv"},{"id":"op-2","outputType":"arrow"}]""" + val parsed = service.parseOperators(json) + + parsed shouldBe List( + OperatorExportInfo("op-1", "csv"), + OperatorExportInfo("op-2", "arrow") + ) + } + + it should "round-trip an empty JSON array to an empty list" in { + service.parseOperators("[]") shouldBe List.empty[OperatorExportInfo] + } + + it should "throw when given a malformed JSON string" in { + an[Exception] should be thrownBy service.parseOperators("not json") Review Comment: Catching `Exception` here is overly broad and could mask unrelated failures (e.g., NPEs) while still passing the test. Since `parseOperators` uses Jackson `ObjectMapper.readValue`, assert a Jackson parsing/processing exception type instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
