aglinxinyuan commented on PR #6685: URL: https://github.com/apache/texera/pull/6685#issuecomment-5040960666
Dug into this. The coverage **is** uploaded and fully processed on these PRs — the only thing missing is the last step, Codecov posting the PR comment. It's the tokenless upload path on fork PRs, not our `codecov.yml` or the diff. These PRs are from forks, so GitHub doesn't hand secrets to the `pull_request` run (`required-checks.yml` correctly uses `pull_request`, not `pull_request_target`). `CODECOV_TOKEN` ends up empty — the frontend job log shows `INPUT_CODECOV_TOKEN:` blank — so the upload falls back to Codecov's tokenless path. Tokenless uploads are rate-limited, and when a batch of them lands together Codecov drops the comment/notify step for most commits. The report itself still processes to `state: complete`; only the comment is skipped. It tracks almost perfectly with how many PRs were opened at once: | Time (UTC) | opened together | got comment | |---|---|---| | 07-16 10:35 | 6 | 5/6 | | 07-20 09:13 | 3 | 3/3 | | 07-20 21:32 | 3 | 1/3 | | 07-21 03:30 | 10 | 0/10 | #6685 was in that 10-PR burst. #6687 was too and stayed silent for a day — until it picked up a `merge main` commit that re-ran CI, and the comment appeared ~7 min later. Re-running CI (or "Update branch") reliably brings it back. Ruled out: not "no coverage change" (`require_changes` defaults to `false`, and several PRs in the dead burst *did* move coverage), not config (identical for every PR), not a missing base report (base commit is `complete`). Two fixes: - **Now** — re-trigger CI on the affected PRs (Update branch / re-run the frontend job), and stagger PR creation instead of opening ~10 together. - **Durable** — move the Codecov upload to a `workflow_run`-triggered workflow: the `pull_request` build uploads the coverage/junit files as artifacts (no secrets, safe for fork code), and a follow-up workflow fires on completion in the base-repo context where `CODECOV_TOKEN` exists and does a tokenized upload. Authenticated uploads aren't rate-limited like tokenless, so comments post reliably even in bursts — it's Codecov's documented pattern for forks. Put up a PR for this: #6730. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
