mengw15 opened a new pull request, #6759:
URL: https://github.com/apache/texera/pull/6759

   ### What changes were proposed in this PR?
   
   Extends the existing `UserDatasetFileRendererComponent` spec to cover the two
   file-content methods it had left untested
   
(`frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.ts`).
   
   3 tests cover:
   
   - `loadTabularFile` — sets the header from the first row and normalizes each 
row's length to the header width; leaves state unchanged for empty data.
   - `readFileAsText` — reads the blob text into `textContent`.
   
   Per the issue's flaky-test note, `FileReader` is **not** left to jsdom's real
   async: it is replaced with a deterministic stub whose `readAsText` fires 
`onload`
   on a microtask (`queueMicrotask`, awaited via `Promise.resolve()`), and the
   global is restored in a `finally` so it survives an assertion failure. No
   production code was changed.
   
   ### Any related issues, documentation, discussions?
   
   Closes #6748
   
   ### How was this PR tested?
   
   Extended unit tests, run locally in `frontend/` (all green; the failure path 
was
   verified by breaking an assertion to confirm the suite goes red):
   
   ```
   ng test --watch=false --include 
src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.spec.ts
   # Test Files 1 passed (1) | Tests 18 passed (18)
   prettier --write <spec>   # clean
   eslint  <spec>            # clean
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to