mengw15 opened a new pull request, #6763:
URL: https://github.com/apache/texera/pull/6763
### What changes were proposed in this PR?
Extends the existing `FiltersComponent` spec to cover the filter-list
helpers it
had left untested
(`frontend/src/app/dashboard/component/user/filters/filters.component.ts`).
> Note: most of the methods the issue lists are already covered —
search-parameter
> assembly (`getSearchKeywords` / `getSearchFilterParameters`),
operator/owner/id
> backend setup (`searchParameterBackendSetup`, asserted via the logged-out
init
> test), the `updateSelected*` handlers, `updateDropdownMenus`, and
> `buildMasterFilterList` date handling. This PR fills the remaining gaps.
6 tests cover:
- `checkIfWorkflowName` — a plain tag is a name, a known-prefix tag (`owner:
…`) is
a filter, an unrecognized prefix is still a name;
- `updateMasterFilterList` — appends new tags, replaces the `ctime` tag in
place,
and drops tags absent from the new list;
- `setMasterFilterList` — emits on `masterFilterListChange` only when the
list
actually changes;
- `removeInvalidFilterTag` — drops the given tag;
- `setDropdownSelectionsToUnchecked` — clears every dropdown checkbox.
Per the issue's timezone note, `getFormattedDateString` is left to the
existing
TZ-safe date tests (which read the local calendar fields, matching the
component's
local `new Date(y, m, d)`); no new timezone-dependent assertion is
introduced. No
production code was changed.
### Any related issues, documentation, discussions?
Closes #6751
### How was this PR tested?
Extended unit tests, run locally in `frontend/` (all green; the failure path
was
verified by breaking an assertion to confirm the suite goes red):
```
ng test --watch=false --include
src/app/dashboard/component/user/filters/filters.component.spec.ts
# Test Files 1 passed (1) | Tests 38 passed (38)
prettier --write <spec> # clean
eslint <spec> # clean
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
