rbelavadi commented on code in PR #5676:
URL: https://github.com/apache/texera/pull/5676#discussion_r3632110612
##########
frontend/src/app/workspace/component/property-editor/operator-property-edit-frame/operator-property-edit-frame.component.ts:
##########
@@ -544,7 +544,11 @@ export class OperatorPropertyEditFrameComponent implements
OnInit, OnChanges, On
* @param event
*/
onFormChanges(event: Record<string, unknown>): void {
- this.sourceFormChangeEventStream.next(event);
+ const requiredFields = this.currentOperatorSchema?.jsonSchema?.required ??
[];
+ const cleanedEvent = Object.fromEntries(
+ Object.entries(event).filter(([key, value]) => value !== null ||
requiredFields.includes(key))
Review Comment:
Fixed. Using loose equality now so both null and undefined get stripped for
optional fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
