roshiiiz opened a new pull request, #6811:
URL: https://github.com/apache/texera/pull/6811
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
This PR introduces a strict 100 MB memory allocation limit when scanning
files using the standard `binary` attribute type.
**Why is it needed?**
Previously, when users mistakenly attempted to read massive files (e.g.,
>8GB) using the `binary` attribute type (instead of the streaming `large
binary` type), the `ByteArrayOutputStream` would attempt to allocate the entire
file into a single contiguous Java byte array. Since standard `byte[]` arrays
max out at ~2.14GB, this inherently fails. Worse, on standard developer laptops
or lower-memory deployments, this massive allocation attempt triggered
immediate `IllegalArgumentException`s or severe JVM Garbage Collection death
spirals, causing the `computing-unit-master` to lock up or crash entirely
without reporting a user-friendly error to the frontend UI.
**What was changed:**
- Added a `MAX_SAFE_SIZE` limit of 100 MB to `FileScanUtils.scala`.
- During the `binary` scan loop, if the byte stream exceeds 100 MB, it is
immediately intercepted and aborted safely.
- Throws a clean, user-friendly `RuntimeException` directly to the frontend
directing the user to use the `large binary` attribute type instead for massive
files, completely preventing the JVM from thrashing or freezing.
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
Closes #3721
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if the
PR
is tested with existing test cases. Make sure to include/update test cases
that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please clarify
how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were not
added,
please describe why they were not added and/or why it was difficult to add.
-->
**Manual Verification:**
1. Uploaded an 8.9 GB CSV test file to the workspace.
2. Created a workflow with the `File Scan` operator.
3. Configured the operator to use the `binary` attribute type (which
intentionally attempts to load the entire file into memory).
4. Ran the workflow.
**Result:** The workflow aborted instantly (in ~3-4 seconds) the moment it
crossed the 100MB threshold. It safely threw the custom user-friendly error
message in the UI and immediately cleaned up the worker thread without any
memory leaks or GC pauses.
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please include the phrase: 'Generated-by: ' followed by the name of the tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Generated-by: Antigravity (DeepMind)
Changed it to 100 Mb instead of 1gb afterwards
<img width="1916" height="870" alt="image"
src="https://github.com/user-attachments/assets/a1df28f5-05cd-47b4-b9f7-20db51210fdc";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
