aglinxinyuan commented on code in PR #6824:
URL: https://github.com/apache/texera/pull/6824#discussion_r3636809497
##########
.github/workflows/codecov-upload.yml:
##########
@@ -169,7 +181,6 @@ jobs:
pull-requests: write # comment on the PR
steps:
- name: Download coverage metadata
- id: dl
continue-on-error: true
Review Comment:
Yes — kept it true on purpose (it's the opposite of the upload job's
download). This one only fetches a `codecov-*` artifact to read the PR number
for the comment; if that can't be found (e.g. the source run produced no
artifacts, so the pattern matches nothing and download-artifact errors),
continue-on-error lets it fall through to the `if: pr != ''` guard and just
skip commenting, instead of hard-failing `notify-failure` itself — which isn't
a required check, so failing it would be invisible noise rather than a signal.
The upload job's download dropped continue-on-error precisely so a genuine
failure surfaces and triggers this job. Added a comment spelling that out in
ef3898c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
