Ma77Ball commented on code in PR #6729:
URL: https://github.com/apache/texera/pull/6729#discussion_r3633850683
##########
amber/src/main/scala/org/apache/texera/amber/engine/common/Utils.scala:
##########
@@ -141,6 +143,7 @@ object Utils extends LazyLogging {
case WorkflowAggregatedState.COMPLETED => 3
case WorkflowAggregatedState.FAILED => 4
case WorkflowAggregatedState.KILLED => 5
+ case WorkflowAggregatedState.CACHE_REUSED => 6
Review Comment:
New status code 6 is not mirrored to the frontend in
`ngbd-modal-workflow-executions.component.ts` (mentioned in the doc comments
above)
> /**
* @param state indicates the workflow state
* @return code indicates the status of the execution in the DB it is 0
by default for any unused states.
* This code is stored in the DB and read in the frontend.
* If these codes are changed, they also have to be changed in
the frontend `ngbd-modal-workflow-executions.component.ts`
*/
Please add the `CacheReused` case there too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
