mengw15 commented on code in PR #6017:
URL: https://github.com/apache/texera/pull/6017#discussion_r3644954562
##########
amber/src/test/scala/org/apache/texera/web/resource/dashboard/file/WorkflowResourceSpec.scala:
##########
@@ -369,6 +372,57 @@ class WorkflowResourceSpec
assert(DashboardWorkflowEntryList.results.length == 2)
}
+ it should "return only single instance of workflow when owned and shared
publicly" in {
Review Comment:
This case ("owned and shared publicly") searches as the owner, so there's
only the owner's single access row — no join fan-out, and it returns 1 result
with or without the fix. The "publicly and explicitly shared" case below is the
real regression test (the extra READ grant is what produces the duplicate rows
pre-fix). Worth either adding an explicit second grant here too so this one
also fails without the fix, or keeping it just as documentation of the
owner+public case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
