zyratlo commented on PR #5265: URL: https://github.com/apache/texera/pull/5265#issuecomment-5074452250
I moved the button out of the mini-map and into the top menu bar next to the AI generate button, and switched the icon to the Jupyter logo. To keep this reviewable, the button and the service it drives are now split across two PRs: - This PR (#5265) provides the service only. JupyterPanelService now exposes the panel visibility methods plus a new jupyterNotebookExists$ signal, and it no longer touches the mini-map (those files are back to their main versions). - #5273 adds the menu button that consumes the service. It calls openJupyterNotebookPanel, and it only appears when the current workflow has an associated notebook, driven by jupyterNotebookExists$. I also updated this PR's title and description to reflect the narrower scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
