aglinxinyuan opened a new pull request, #6877:
URL: https://github.com/apache/texera/pull/6877

   ### What changes were proposed in this PR?
   
   Adds `SQLSourceOpExecSpec` (27 tests) for a file that had **0% coverage**. A 
small in-spec subclass supplies the three DB hooks (`establishConn` returns an 
injected `Connection`, `loadTableNames`/`addFilterConditions` are 
configurable), so the query-building surface is exercised directly:
   - `generateSqlQuery` across plain / filtered / LIMIT / LIMIT+OFFSET / 
OFFSET-only / progressive combinations, and the `None` cases when the limit is 
non-positive;
   - `addBaseSelect`, `addLimit`, `addOffset`, `terminateSQL` fragments;
   - `addBatchSlidingWindow` for LONG / TIMESTAMP / DOUBLE (incl. the inclusive 
final window) and its no-batch-column and unsupported-type errors;
   - `batchAttributeToString` formatting per type;
   - `hasNextQuery` bound transitions; `open()` table validation and 
progressive-config rejection;
   - `fetchBatchByBoundary` auto MIN/MAX probes and the `produceTuple` iterator 
(parameter binding order, manual offset skipping, null columns, result-set 
close-out) via ScalaMock JDBC doubles.
   
   The descriptor JSON is produced from a real `PostgreSQLSourceOpDesc` so the 
polymorphic `operatorType` tag resolves exactly as in production. No source 
changes.
   
   ### Any related issues, documentation, discussions?
   
   Closes #6874.
   
   ### How was this PR tested?
   
   `sbt -java-home <jbr-17> "WorkflowOperator/testOnly *SQLSourceOpExecSpec"` 
-> 27 succeeded, 0 failed. `Test/scalafmtCheck` + `Test/scalafix --check` clean.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to