mengw15 commented on code in PR #6880: URL: https://github.com/apache/texera/pull/6880#discussion_r3649685557
########## amber/src/main/python/texera_run_python_worker.py: ########## @@ -18,8 +18,19 @@ import base64 import json import sys +import warnings from loguru import logger +# `fs` (imported transitively by the core import below) pulls in pkg_resources +# at import time (#4199), which emits this deprecation warning on stderr in +# every spawned worker. It is not actionable on our side, so filter it before +# the import chain runs. Mirrored for pytest in amber/pyproject.toml. +warnings.filterwarnings( Review Comment: Narrow, well-scoped filter — no objection to silencing this. One thing worth surfacing: this warning was also the only recurring signal that we're pinned on an EOL `fs` (2.4.16 is the last release) and holding setuptools below the pkg_resources removal (#4199). Once it's quiet, that debt only lives in this comment. There's no open tracking issue for migrating off PyFilesystem2 / handling the eventual pkg_resources removal — worth opening one and linking it here so the debt stays visible after the reminder is gone. Not blocking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
