aglinxinyuan opened a new pull request, #6888:
URL: https://github.com/apache/texera/pull/6888

   ### What changes were proposed in this PR?
   
   Adds `MySQLSourceOpExecSpec` and `PostgreSQLSourceOpExecSpec` (34 tests) for 
the two `SQLSourceOpExec` dialect subclasses, both previously at **0% 
coverage**. They mirror the harness already used by `SQLSourceOpExecSpec`: an 
in-spec subclass supplying the DB hooks, a `descString` built from a real 
dialect OpDesc so the polymorphic `operatorType` tag resolves, and ScalaMock 
JDBC doubles.
   
   Covered per dialect:
   - `establishConn` — the exact JDBC URL/properties it dials, and that a 
`SQLException` propagates rather than being swallowed;
   - the `information_schema` table-name query, its bound parameter, draining 
the `ResultSet`, and closing both it and the statement (plus the empty-listing 
case);
   - `open()` — accepting a present table and rejecting an absent one;
   - the dialect-specific keyword search — MySQL `MATCH(...) AGAINST (? IN 
BOOLEAN MODE)` and PostgreSQL `to_tsvector`, keeping the keyword as a bind 
parameter — plus the toggle-off, missing-column and non-STRING-column error 
branches.
   
   No source changes.
   
   ### Any related issues, documentation, discussions?
   
   Closes #6885.
   
   ### How was this PR tested?
   
   `sbt -java-home <jbr-17> "WorkflowOperator/testOnly *MySQLSourceOpExecSpec 
*PostgreSQLSourceOpExecSpec"` -> 34 succeeded, 0 failed. `Test/scalafmtCheck` + 
`Test/scalafix --check` clean.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to