mengw15 commented on code in PR #6903:
URL: https://github.com/apache/texera/pull/6903#discussion_r3651832193
##########
amber/src/main/python/core/util/customized_queue/linked_blocking_multi_queue.py:
##########
@@ -418,15 +421,15 @@ def add_sub_queue(self, key: K, priority: int) ->
Optional[SubQueue]:
added = True
break
elif pg.priority > priority:
- new_pg =
LinkedBlockingMultiQueue.PriorityGroup(priority)
+ new_pg = self.PriorityGroup(priority)
new_pg.add_queue(sub_queue)
self.priority_groups.append(new_pg)
added = True
Review Comment:
Confirmed — this is a real defect, not introduced here: the `i` counter in
that loop is maintained for exactly this insert and is otherwise unused.
`priority_groups` must stay sorted because `DefaultSubQueueSelection` walks it
in order without comparing priorities, so registering a data channel before its
control channel can cost control its priority. It's out of scope for this PR
(which repairs the removal paths), so I filed it as #6905 and fixed it
separately in #6906.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
