Copilot commented on code in PR #6907:
URL: https://github.com/apache/texera/pull/6907#discussion_r3651843077
##########
common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/intervalJoin/IntervalOpExecSpec.scala:
##########
@@ -519,6 +519,34 @@ class IntervalOpExecSpec extends AnyFlatSpec with
BeforeAndAfter {
}
}
+ it should "fall back to day semantics when timeIntervalType is left unset"
in {
+ // Every other test builds the desc through the 6-argument constructor,
+ // which always supplies Some(...). The field is declared
+ // `var timeIntervalType: Option[TimeIntervalType] = _`, so leaving it
unset
+ // is the only way to reach the `case None` arm of the timestamp branch.
Review Comment:
The comment still refers to reaching the `case None` arm, but the production
code now uses a catch-all (`case _`) for the fallback. This is now misleading
for future readers trying to understand what this test is exercising.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
