gupta-sahil01 opened a new pull request, #6914:
URL: https://github.com/apache/texera/pull/6914
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
**Root cause.** The frontend `start` script runs `ng serve` on Node's
default V8 heap. Node auto-sizes that limit from available RAM — on an 8 GB
machine it's only ~2.2 GB — and `ng serve` exceeds it during a build, crashing
with `FATAL ERROR: Reached heap limit — JavaScript heap out of memory`. Because
the script uses `concurrently --kill-others`, the crash also tears down the
y-websocket process, and the dev server does not recover without a manual
restart. The `build` script already passes `--max-old-space-size=8192`, so only
the dev server was affected — an inconsistency between the two.
**Fix.** Give `ng serve` the same heap ceiling the production build already
uses, by invoking Node directly on the CLI entry point (the `ng` wrapper can't
forward the flag):
One-line change to `frontend/package.json`. No effect on developers with 16
GB+ RAM (their default heap was already large enough, which is why this went
unnoticed); it simply removes the crash on lower-RAM machines.
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
### Any related issues, documentation, discussions?
- Closes #6859
<!--
Please use this section to link other resources if not mentioned already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
### How was this PR tested?
Reproduced and verified on an 8 GB-RAM machine:
- **Before:** `yarn start` (→ `ng serve`) crashed with `Reached heap limit —
JavaScript heap out of memory`, with V8 topping out around ~2040 MB. On this
machine it failed on the **initial** build ("Generating browser application
bundles"), not only on incremental rebuilds — so the dev server never even
reached a serving state.
- **After:** with the heap flag, `yarn start` compiles to "Compiled
successfully" and serves `localhost:4200`, and editing/saving a template no
longer crashes it.
No env-var workaround (`NODE_OPTIONS=--max-old-space-size=…`) is needed
anymore — the script carries the limit itself.
<!--
If tests were added, say they were added here. Or simply mention that if the
PR
is tested with existing test cases. Make sure to include/update test cases
that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please clarify
how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were not
added,
please describe why they were not added and/or why it was difficult to add.
-->
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Anthropic Claude (Claude Code)
<!--
If generative AI tooling has been used in the process of authoring this PR,
please include the phrase: 'Generated-by: ' followed by the name of the tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
