aglinxinyuan opened a new pull request, #7025: URL: https://github.com/apache/texera/pull/7025
### What changes were proposed in this PR? Adds 42 tests across five `common/workflow-core` classes (49 -> 91 in these suites). No source changes; the three extended specs are **pure insertions**. - **`PartitionInfo`**: `satisfies`/`merge` sensitivity to hash-attribute contents *and order*, `RangePartition`'s always-Unknown merge override and the companion's collapse to `UnknownPartition` on an empty attribute list, plus the polymorphic-JSON contract (each subtype tagged with its registered type id, base-type round-trip preserving range bounds). - **`JGitVersionControl`**: `initRepo`'s branch extraction matching what JGit reports, `getRootFileNodeOfCommit` on an empty tree and on depth-two nested directories, symbolic refs (`HEAD`) on both read paths, per-commit content after re-staging a modified file, binary-safe copies through both stream APIs, and a staged deletion reported as uncommitted until committed. - **`Tuple`**: constructor null guards, positional `getField` and its out-of-range failure, `inMemSize` growth, and the Builder's missing-attribute / duplicate-add / `addSequentially` size-mismatch paths. - **`LargeBinary`** (new spec): URI validation with exact messages (including the case-sensitive `s3://` guard), bucket/object-key parsing with the empty-path branch, value semantics, the thread-local base-URI constructor and its unset failure, and Jackson `@JsonValue`/`@JsonCreator` behavior. - **`OnIceberg`** (new spec): `expireSnapshots` collapsing three snapshots to one while keeping every live row, idempotence, a no-op on a snapshot-less table, and the `NoSuchTableException` message — driven against a **local Hadoop catalog on a temp `file:/` warehouse**, so no REST/S3 backend is needed. A few defensive branches were left uncovered rather than contrived (unreachable `return null` guards in `initRepo`, and a parent-node creation branch the tree walk can't reach); they're listed in the review notes. ### Any related issues, documentation, discussions? Closes #7023. ### How was this PR tested? `sbt -java-home <jbr-17> "WorkflowCore/testOnly *PartitionInfoSpec *JGitVersionControlSpec *TupleSpec *LargeBinarySpec *OnIcebergSpec"` -> 91 succeeded, 0 failed. `Test/scalafmtCheck` + `Test/scalafix --check` clean. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8 [1M context]) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
