aglinxinyuan opened a new issue, #7027: URL: https://github.com/apache/texera/issues/7027
@ ### Task Summary Two generic helpers in the amber engine have no production caller. Both were given unit tests during the 2026 coverage work, which is why they currently look live. | Symbol | Location | Lines (src + spec) | Last production caller | | --- | --- | ---: | --- | | `OrderingEnforcer[T]` | `amber/.../architecture/messaginglayer/OrderingEnforcer.scala` | 53 + 150 | removed by #2208 (2023-11-15) | | `Utils.retry` | `amber/.../engine/common/Utils.scala:72-87` | 26 + 35 | none in the current history | **`OrderingEnforcer`** was the extracted, generic form of the FIFO / exactly-once reorder buffer. #2208 inlined that logic into `AmberFIFOChannel`, which still carries the identical header comment `/* The abstracted FIFO/exactly-once logic */` and re-declares the same `ofoMap` / `current` / `isDuplicated` / `isAhead` / `stash` / `enforceFIFO` members. The generic copy has been stranded ever since. Note there is a separate, live `OrderEnforcer` trait (no `-ing`) in `architecture/logreplay/`. They are unrelated; only the `messaginglayer` one is dead. **`Utils.retry`** is an exponential-backoff combinator whose only remaining reference is its own tail-recursive call. Its `logger.warn` is the sole use of the logger in `object Utils`, so `extends LazyLogging`, the `LazyLogging` import and `import scala.annotation.tailrec` all become unused once it is removed — leaving them would fail `scalafixAll --check`. Removing both is a pure deletion with no behaviour change: −268 lines. Out of scope: retry/backoff is also hand-rolled in `LakeFSStorageClient.retryWithBackoff` and `FileService.awaitDependency`. Consolidating those two surviving copies is a separate follow-up. ### Task Type - [x] Refactor / Cleanup @ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
