aglinxinyuan opened a new pull request, #7040:
URL: https://github.com/apache/texera/pull/7040
### What changes were proposed in this PR?
`AuthConfig.jwtSecretKey` hand-rolls a double-checked-locking lazy
initializer — a `@volatile var`, a null sentinel and a `synchronized` block —
to compute one value once. Scala's `lazy val` is that exact pattern, generated
by the compiler.
```scala
// before
@volatile private var secretKey: String = _
def jwtSecretKey: String = {
synchronized {
if (secretKey == null) {
secretKey = conf.getString("auth.jwt.256-bit-secret").toLowerCase()
match {
case "random" => getRandomHexString
case key => key
}
}
}
secretKey
}
// after
lazy val jwtSecretKey: String =
conf.getString("auth.jwt.256-bit-secret").toLowerCase() match {
case "random" => getRandomHexString
case key => key
}
```
Behaviour is preserved on every axis I checked:
| | hand-rolled | `lazy val` |
| --- | --- | --- |
| initialized at most once | yes | yes |
| safe under concurrent first access | yes (`synchronized`) | yes
(compiler-generated DCL) |
| safe publication of the result | yes (`@volatile`) | yes |
| behaviour if the initializer throws | leaves the field null, retries next
call | initialized bit not set, retries next call |
| call-site shape | `AuthConfig.jwtSecretKey` | unchanged |
The single caller, `JwtAuth.scala:35` (`final val TOKEN_SECRET =
AuthConfig.jwtSecretKey`), needs no change — `def` and `lazy val` are
indistinguishable at the call site. `getRandomHexString` stays a private `def`,
so `AuthConfigSpec`'s reflective lookup of it still resolves.
−14 lines, +6.
### Any related issues, documentation, discussions?
Closes #7039
### How was this PR tested?
Existing tests only — this PR adds none, since it is a behaviour-preserving
rewrite already covered by `AuthConfigSpec` (which pins both the
configured-secret path and that the value is memoized across calls).
Locally, from the repo root with Java 17:
- `sbt "scalafixAll --check"` — clean.
- `sbt scalafmtCheckAll` — clean.
- `sbt "Config/testOnly *AuthConfigSpec"` — 3 tests, all pass, unmodified.
The whole-repo scalafix/scalafmt run also compiles `common/auth`, so the
`JwtAuth` call site is covered.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
