Yicong-Huang opened a new pull request, #7062:
URL: https://github.com/apache/texera/pull/7062

   ### What changes were proposed in this PR?
   
   The `contributor-checks` job in `.github/workflows/contributor-checks.yml` 
gates on `github.event.sender.type != 'Bot'` so it won't nag automated PR/issue 
openers about not following the template.
   
   That gate catches GitHub App bots (e.g. `dependabot[bot]`, whose account 
`type` is `Bot`) but **not** bots that run under a regular User account. 
Renovate's `renovate-bot` account has `type: User`, so it slipped through and 
received the "the description doesn't follow our template" warning on every 
dependency-update PR (e.g. 
[#7060](https://github.com/apache/texera/pull/7060#issuecomment-5123597082)).
   
   This PR additionally skips senders whose login ends in `-bot`, covering 
`renovate-bot` and any future User-account bots:
   
   ```yaml
   if: >-
     github.event.sender.type != 'Bot' &&
     !endsWith(github.event.sender.login, '-bot')
   ```
   
   ### How was this PR tested?
   
   - Confirmed via the GitHub API that `renovate-bot` has `type: User` (not 
`Bot`), which is why the existing `sender.type != 'Bot'` gate did not exclude 
it.
   - Validated the workflow YAML parses and the folded `if:` expression 
resolves to the intended single-line condition.
   - The change is confined to the job-level `if:` gate; no `run:` step or 
untrusted-input interpolation is touched.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Yes — drafted with Claude Code, reviewed by the author.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to