Copilot commented on code in PR #7050:
URL: https://github.com/apache/texera/pull/7050#discussion_r3678701722
##########
sql/changelog.xml:
##########
@@ -24,6 +24,15 @@
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.9.xsd";>
+ <!-- Widen execution size columns to BIGINT (#6978).
+ Kept as id 29 to match main: Liquibase identifies an applied change by
+ its id, so a deployment upgrading from v1.2 to main will see changeSet
+ 29 as already run instead of re-executing it. Ids 23-28 are main-only
+ changes that do not exist on this branch. -->
Review Comment:
The changelog comment says Liquibase identifies an applied change by its id,
but Liquibase tracks changeSets by the tuple (id, author, and changelog file
path). If the goal is to prevent re-execution when upgrading to main, the
comment (and potentially the metadata) should reflect that requirement to avoid
giving a false guarantee.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
