Yicong-Huang commented on code in PR #7028:
URL: https://github.com/apache/texera/pull/7028#discussion_r3678840355
##########
amber/src/main/scala/org/apache/texera/amber/engine/common/Utils.scala:
##########
@@ -59,33 +57,6 @@ object Utils extends LazyLogging {
}
val AMBER_HOME_FOLDER_NAME = "amber";
- /**
- * Retry the given logic with a backoff time interval. The attempts are
executed sequentially, thus blocking the thread.
- * Backoff time is doubled after each attempt.
- *
- * @param attempts total number of attempts. if n <= 1 then it
will not retry at all, decreased by 1 for each recursion.
- * @param baseBackoffTimeInMS time to wait before next attempt, started
with the base time, and doubled after each attempt.
- * @param fn the target function to execute.
- * @tparam T any return type from the provided function fn.
- * @return the provided function fn's return, or any exception that still
being raised after n attempts.
- */
- @tailrec
- def retry[T](attempts: Int, baseBackoffTimeInMS: Long)(fn: => T): T = {
Review Comment:
Can we keep retry? Some places may use this logic, e.g., testing logic in
LoopIntergrationTest to retry send EndWorker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
