Yicong-Huang commented on PR #7113: URL: https://github.com/apache/texera/pull/7113#issuecomment-5126613514
Resolved as a **source-only (application-level)** backport. The real fix — server-side rejection of invalid/duplicate renames in `DatasetResource.updateDatasetName` (`validateDatasetName` + a `duplicateExists` pre-check) — applies cleanly and fully closes the bug (rename can no longer create same-name datasets → no more `TooManyRowsException` / path corruption). Kept the 4 application-level rename tests in `DatasetResourceSpec`. **Dropped the DDL deliberately** (`sql/changelog.xml` changeset 28, `sql/updates/28.sql`, and the `texera_ddl.sql` UNIQUE line): v1.2's changelog has no changesets 23–27 and `sql/updates` ends at 22, so adding id 28 would diverge the release branch's migration history, and `28.sql` is a data-mutating dedup migration — unsafe to ship on a release line. The `(owner_uid, name)` unique constraint was only a concurrent-race backstop; the app-level pre-check already rejects duplicates. Accordingly I also dropped the two spec tests that exercised the DB constraint directly (`failOnDuplicateDatasetName` is kept in source as a harmless dormant guard). Frontend pre-validation was left off (backend rejection is authoritative; the UI change also touched a main-only `card-item` component). Marking ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
