Yicong-Huang commented on PR #7111: URL: https://github.com/apache/texera/pull/7111#issuecomment-5126632070
Reduced to the actual bug fix. Root cause (#6215): the datasets list defaulted to `SortMethod.EditTimeDesc`, but datasets have no last-modified timestamp, so the sort key was NULL for every row → undefined order. Fix: default to `SortMethod.CreateTimeDesc` (newest-first) in `user-dataset.component.ts` and the hub dataset branch of `hub-search-result.component.ts`, plus a spec asserting the default. I dropped everything else the PR carried, because it is main-only feature scaffolding rather than part of this fix: the `showEditTime`/`showExecutionTime` sort-button inputs and the **By Execution Time** option (`execSort`/`SortMethod.ExecutionTimeDesc`, added on main by #5890 — not on v1.2), the new sort-button UI added to the datasets toolbar, and `sort-button.component.spec.ts` (doesn't exist on v1.2). Net change is 3 files / +13 −1, no new UI or enum values. Marking ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
