aglinxinyuan commented on PR #7119: URL: https://github.com/apache/texera/pull/7119#issuecomment-5128029573
All ten addressed — the must-fix in 93fb507, plus the three description-level notes: - **Title** → `refactor(util): host one exponential-backoff retry` (49 chars). You're right that `common` is a directory, not a module. - **Why a new module rather than `common/workflow-core`** (proposal 1 in #7095) is now a paragraph in the description: `workflow-core` isn't reachable from `Auth`, `ConfigService` or `AccessControlService`, so hosting it there leaves future callers in those modules writing their own loop — the thing this PR exists to stop. `common/config` is reachable from everything and already carries `ConfigParserUtil`, but a retry helper isn't configuration. - **The two loops left alone** are now #7124, with the specific blocker for each recorded there rather than only in this description: `URLFetchUtil` retries with no delay at all (backoff adds ~3 s before a dead URL fails), and `PythonProxyClient` needs a delay-multiplier knob plus a decision about its `WorkflowRuntimeException` give-up type. Re-verified after the changes: `Util/jacoco` 11 passed (up from 10 with the new non-fatal-`Error` case), `FileServiceSpec` 12, `LakeFSStorageClientSpec` 5, amber's two retry specs 27, and scalafix/scalafmt clean on all four modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
