rbelavadi commented on code in PR #7043:
URL: https://github.com/apache/texera/pull/7043#discussion_r3685858773
##########
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.spec.ts:
##########
@@ -301,7 +312,14 @@ describe("DatasetDetailComponent upload queue", () => {
it("renders the virtualized pending list and re-measures viewports on panel
expand", async () => {
dropFiles("f1.txt", "f2.txt", "f3.txt", "f4.txt", "f5.txt");
+
+ // The upload UI lives in the "Versions & Files" tab; nz-tabs does not
render a
+ // tab's content into the DOM until it has been selected at least once.
+ const tabButtons: NodeListOf<HTMLElement> =
fixture.nativeElement.querySelectorAll(".ant-tabs-tab-btn");
+ const versionsTab = Array.from(tabButtons).find(tab =>
tab.textContent?.includes("Versions & Files"));
+ versionsTab?.click();
Review Comment:
Added an explicit expect(...).toBeTruthy() before clicking, so the test
fails clearly if the tab isn't found instead of silently no-op-ing. Applied the
same fix to the other instance of this pattern in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
