PG1204 opened a new pull request, #7143:
URL: https://github.com/apache/texera/pull/7143
### What changes were proposed in this PR?
Pure internal rename: `PythonCodegenBase` -> `HuggingFaceCodegenBase`
(object, file, and spec).
Despite the generic name, this object is HF-specific, it lives in
`.../huggingFace/codegen/`, is used only there, and is the shared base of the
Hugging Face per-task `TaskCodegen`s. The old name led a reviewer to ask
whether the HF logic belonged elsewhere (comment on #6972); the new name
matches the sibling codegens and `HuggingFaceInferenceOpDesc`.
Also updated the references in `HuggingFaceInferenceOpDesc.scala`,
`ImageTaskCodegen.scala`, and `TaskCodegen.scala`. Behavior-neutral: no change
to the generated Python, workflow JSON, or any public API; git tracks both
files as renames.
### Any related issues, documentation, discussions?
Closes #7140
Follow-up to the review discussion on #6972.
### How was this PR tested?
No new tests as this is a rename, and existing coverage confirms it's
behavior-neutral.
sbt "WorkflowOperator/testOnly
org.apache.texera.amber.operator.huggingFace.*"
The full HF package passes (124 tests), including
`PythonCodeRawInvalidTextSpec`, which
py-compiles the generated Python of all 117 operators — confirming the
generated output is
unchanged. scalafmt clean.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
