tanishqgandhi1908 commented on code in PR #6502:
URL: https://github.com/apache/texera/pull/6502#discussion_r3692658757
##########
file-service/src/main/scala/org/apache/texera/service/resource/DatasetResource.scala:
##########
@@ -2280,7 +2298,8 @@ class DatasetResource extends LazyLogging {
)
val owner = getOwner(ctx, did)
- val fullPath = s"${owner.getEmail}/${dataset.getName}/$coverImage"
+ val fullPath =
+
s"${ResourceType.Datasets}/${owner.getEmail}/${dataset.getName}/$coverImage"
Review Comment:
DatasetResource only serves dataset endpoints, so it can't be shared with
models. Made logicalPath generic so path-building hardcodes nothing; the type
is declared once as a class val and passed in. But still have to assign the
value once in this pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
